[ 
https://issues.apache.org/jira/browse/BEAM-6770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785823#comment-16785823
 ] 

Michael Luckey commented on BEAM-6770:
--------------------------------------

Sure you could also add an explicit configuration. And do an e.g.  'testRuntime 
extends optional'.

This would not help getting this into pom.xml with 'optional=true', though.

And from my personal point of view, as it is *required* for running tests, 
maybe misleading. If it would be required for compilation, but optional for 
runtime, ia separate, explicitly optional configuration would make more sense, 
imho.

And as far as I understand, this  'optional=true' is more a documentation 
anyhow to help aligning on a proper version, I think adding this to the doc 
should suffice - at least for now.

With gradle 5.3 there might be a native solution to this problem in general. 
Lets see.

 

> Correct zstd-jni dependency scope to optional
> ---------------------------------------------
>
>                 Key: BEAM-6770
>                 URL: https://issues.apache.org/jira/browse/BEAM-6770
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Romain Manni-Bucau
>            Priority: Major
>
> Beam 2.11.0 introduced a new transitive dep aka zstd-jni. AFAIK it is not 
> needed in most cases so shouldn't be here by default. Also saw it was 
> configured as shadow in the sdk core java module so not sure it is a gradle 
> build bug or intended to be like that but I think sdk-core-java should be 
> cleaned up cause it is now very fast and does not match a lot of usage. 
> Finally this lib being native it is not that sane to bring it by default, in 
> particular with the dockerization happening right now and the goal to have a 
> light container stack (which often implies to not use standard linux as FROM).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to