[
https://issues.apache.org/jira/browse/BEAM-5663?focusedWorklogId=209165&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-209165
]
ASF GitHub Bot logged work on BEAM-5663:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/19 21:44
Start Date: 06/Mar/19 21:44
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #7988: [BEAM-5663]
Add Python 3.6 tox environment
URL: https://github.com/apache/beam/pull/7988#discussion_r263149056
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
##########
@@ -217,6 +218,9 @@ def test_gbk_side_input(self):
main | beam.Map(lambda a, b: (a, b), beam.pvalue.AsDict(side)),
equal_to([(None, {'a': [1]})]))
+ @unittest.skipIf(sys.version_info >= (3, 6, 0) and
+ os.environ.get('RUN_SKIPPED_PY36_TESTS') != '1',
Review comment:
It is sufficient to have one variable RUN_SKIPPED_PY3_TESTS - we only need a
way to override the skip decorator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 209165)
Time Spent: 20m (was: 10m)
> Add tox suites for various Python 3 versions (3.5, 3.6, 3.7)
> ------------------------------------------------------------
>
> Key: BEAM-5663
> URL: https://issues.apache.org/jira/browse/BEAM-5663
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Manu Zhang
> Assignee: Robbe
> Priority: Major
> Labels: triaged
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, Python 3.5.2 is set up for Jenkins tests but we've seen test
> failings across various Python 3 versions. It will be valuable to add tox
> suites for Python 3.4, 3.5, 3.6 and 3.7
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
