[
https://issues.apache.org/jira/browse/BEAM-5663?focusedWorklogId=211760&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-211760
]
ASF GitHub Bot logged work on BEAM-5663:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/19 14:54
Start Date: 12/Mar/19 14:54
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #7988: [BEAM-5663]
Add Python 3.6 tox environment
URL: https://github.com/apache/beam/pull/7988#discussion_r264719356
##########
File path: sdks/python/apache_beam/typehints/trivial_inference_test.py
##########
@@ -34,20 +34,32 @@ class TrivialInferenceTest(unittest.TestCase):
def assertReturnType(self, expected, f, inputs=()):
self.assertEquals(expected, trivial_inference.infer_return_type(f, inputs))
+ @unittest.skipIf(sys.version_info >= (3, 6, 0) and
Review comment:
It may be easier to move the skip declaration to skip entire `class
TrivialInferenceTest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 211760)
Time Spent: 2h (was: 1h 50m)
> Add tox suites for various Python 3 versions (3.5, 3.6, 3.7)
> ------------------------------------------------------------
>
> Key: BEAM-5663
> URL: https://issues.apache.org/jira/browse/BEAM-5663
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Manu Zhang
> Assignee: Robbe
> Priority: Major
> Labels: triaged
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Currently, Python 3.5.2 is set up for Jenkins tests but we've seen test
> failings across various Python 3 versions. It will be valuable to add tox
> suites for Python 3.4, 3.5, 3.6 and 3.7
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
