[
https://issues.apache.org/jira/browse/BEAM-6619?focusedWorklogId=209173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-209173
]
ASF GitHub Bot logged work on BEAM-6619:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/19 22:02
Start Date: 06/Mar/19 22:02
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #7946: [BEAM-6619]
[BEAM-6593] Add gcsio integration tests to postcommit
URL: https://github.com/apache/beam/pull/7946#discussion_r263155332
##########
File path: sdks/python/apache_beam/examples/streaming_wordcount_it_test.py
##########
@@ -81,7 +81,7 @@ def tearDown(self):
@attr('IT')
def test_streaming_wordcount_it(self):
# Build expected dataset.
- expected_msg = [('%d: 1' % num) for num in range(DEFAULT_INPUT_NUMBERS)]
+ expected_msg = [(b'%d: 1' % num) for num in range(DEFAULT_INPUT_NUMBERS)]
Review comment:
I think we should instead decode `bytes` that we receive from PubSub in
https://github.com/apache/beam/blob/79f8e34fc75c59297c0c7f07ce53325ce96bb5cf/sdks/python/apache_beam/io/gcp/tests/pubsub_matcher.py#L106.
The matcher expects strings:
https://github.com/apache/beam/blob/79f8e34fc75c59297c0c7f07ce53325ce96bb5cf/sdks/python/apache_beam/io/gcp/tests/pubsub_matcher.py#L58
PubSub client returns bytes:
https://github.com/apache/beam/blob/a5ed104aeac91781492523808fa4d3df6f2e55f7/sdks/python/apache_beam/io/gcp/pubsub.py#L60
Given this is a test code we can assume a 'utf-8' encoding
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 209173)
Time Spent: 9h 40m (was: 9.5h)
> Add PostCommit suite for integration tests on DataflowRunner
> ------------------------------------------------------------
>
> Key: BEAM-6619
> URL: https://issues.apache.org/jira/browse/BEAM-6619
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Labels: triaged
> Fix For: Not applicable
>
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
