[
https://issues.apache.org/jira/browse/BEAM-6619?focusedWorklogId=209227&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-209227
]
ASF GitHub Bot logged work on BEAM-6619:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/19 23:12
Start Date: 06/Mar/19 23:12
Worklog Time Spent: 10m
Work Description: markflyhigh commented on pull request #7946:
[BEAM-6619] [BEAM-6593] Add gcsio integration tests to postcommit
URL: https://github.com/apache/beam/pull/7946#discussion_r263174073
##########
File path: sdks/python/apache_beam/examples/streaming_wordcount_it_test.py
##########
@@ -81,7 +81,7 @@ def tearDown(self):
@attr('IT')
def test_streaming_wordcount_it(self):
# Build expected dataset.
- expected_msg = [('%d: 1' % num) for num in range(DEFAULT_INPUT_NUMBERS)]
+ expected_msg = [(b'%d: 1' % num) for num in range(DEFAULT_INPUT_NUMBERS)]
Review comment:
+1 We should use `str` to do string operations in SDK, while use `bytes` to
communicate with PubSub.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 209227)
Time Spent: 9h 50m (was: 9h 40m)
> Add PostCommit suite for integration tests on DataflowRunner
> ------------------------------------------------------------
>
> Key: BEAM-6619
> URL: https://issues.apache.org/jira/browse/BEAM-6619
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Labels: triaged
> Fix For: Not applicable
>
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
