[
https://issues.apache.org/jira/browse/BEAM-12100?focusedWorklogId=636146&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636146
]
ASF GitHub Bot logged work on BEAM-12100:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/21 22:57
Start Date: 09/Aug/21 22:57
Worklog Time Spent: 10m
Work Description: benWize commented on pull request #15174:
URL: https://github.com/apache/beam/pull/15174#issuecomment-895604449
Hi @ibzib, I overrode `identity()` in `LongSum` as you suggested, it was
necessary to override `identity()` for the other sum types as well.
I found out that `VarianceFn` and `CovarianceFn` were throwing an
ArithmeticException like in
https://ci-beam.apache.org/job/beam_PreCommit_SQL_Commit/4013/testReport/junit/org.apache.beam.sdk.extensions.sql/BeamSqlDslSqlStdOperatorsTest/testVARPOP/
so I added a check when count and variance are zero to avoid the division
undefined exception.
I am stuck now with a couple of errors related to the incompatibility of
Coders like in
https://ci-beam.apache.org/job/beam_PreCommit_SQL_Java11_Commit/2966/testReport/junit/org.apache.beam.sdk.extensions.sql.zetasql/ZetaSqlDialectSpecTest/testArrayAggZetasql/
and
https://ci-beam.apache.org/job/beam_PreCommit_SQL_Java11_Commit/2966/testReport/junit/org.apache.beam.sdk.extensions.sql.zetasql/ZetaSqlDialectSpecTest/testCountIfZetaSQLDialect/.
Do you have a suggestion of how should I proceed with these?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 636146)
Time Spent: 2h 40m (was: 2.5h)
> SUM should error when overflow/underflow occurs.
> ------------------------------------------------
>
> Key: BEAM-12100
> URL: https://issues.apache.org/jira/browse/BEAM-12100
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> SELECT SUM(col1) FROM (SELECT CAST(9223372036854775807 as int64) as col1
> UNION ALL SELECT CAST(1 as int64))
> should return an error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
