[
https://issues.apache.org/jira/browse/BEAM-12740?focusedWorklogId=636894&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636894
]
ASF GitHub Bot logged work on BEAM-12740:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/21 13:38
Start Date: 11/Aug/21 13:38
Worklog Time Spent: 10m
Work Description: scwhittle commented on pull request #15301:
URL: https://github.com/apache/beam/pull/15301#issuecomment-896834893
PTAL, I removed the hacks for testing since the performance seemed greatly
improved.
Additionally I removed the unnecessary delete of renamed files in
FileBasedSink by improving FileSystems.remove to always delete src files (even
if the copy is skipped due to dest existing and that being filtered).
I added a unit test for rename by adding support to inject a batch object.
The apiary BatchRequest object is difficult to mock so I opted for mocking
above that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 636894)
Remaining Estimate: 0h
Time Spent: 10m
> Reduce and backoff GCS metadata operations when writing to GCS files
> --------------------------------------------------------------------
>
> Key: BEAM-12740
> URL: https://issues.apache.org/jira/browse/BEAM-12740
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Reporter: Sam Whittle
> Assignee: Sam Whittle
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When issuing GCS operations affecting metadata (ie file-level operations not
> read/write operations), GCS may return errors indicating backoff. See
> https://cloud.google.com/storage/docs/request-rate#ramp-up
> If such errors are encountered, currently the exception is not handled by
> GcsUtil.java and is propagated, causing retries and backoff of all operations
> at a higher level. Instead we should backoff and retry only such files that
> require it.
> Additionally FileBasedSink issues deletes for files that have been renamed.
> The rename itself should take care of removing the original file and thus we
> can reduce some metadata operations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
