[
https://issues.apache.org/jira/browse/BEAM-11873?focusedWorklogId=642794&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-642794
]
ASF GitHub Bot logged work on BEAM-11873:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/21 11:22
Start Date: 27/Aug/21 11:22
Worklog Time Spent: 10m
Work Description: AydarZaynutdinov commented on pull request #14856:
URL: https://github.com/apache/beam/pull/14856#issuecomment-907130750
Thanks @aromanenko-dev. As I understood I should:
- rename method `withReturningResults()` to `withWriteResults()`.
- keep old method with name `withResults()` (do not rename it to
`withVoidResults`).
- change back `private` to `public` access for `writeVoid` method.
About other discussions:
- [records by
batches](https://github.com/apache/beam/pull/14856#discussion_r644967332). As I
understood Vitaliy gave clarify answer why he had used `execute()` method
instead of `executeBatch()`. So I guess I should leave it like it is now -> use
`execute()`.
- [wrap up
`V`](https://github.com/apache/beam/pull/14856#discussion_r644964072). I'm not
sure that we need this wraping, becaus a new abstract class `JdbcWriteResult`
will no have any rules or parameters and as a result it would be just a empty
class. May be it would be better transform `JdbcWriteResult` to empty
interface? So it would be like a marker for each`V`. Could you please share
your thoughts?
Is there anything else I should address?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 642794)
Time Spent: 4.5h (was: 4h 20m)
> Add support for writes returning values
> ---------------------------------------
>
> Key: BEAM-11873
> URL: https://issues.apache.org/jira/browse/BEAM-11873
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
> Reporter: Maxim Ivanov
> Assignee: Vitaly Terentyev
> Priority: P3
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> SQL allows returning values from INSERT or UPDATE queries. It would be great
> if these values were returned from write operation and could be processed by
> further PTransforms
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
