[
https://issues.apache.org/jira/browse/BEAM-11873?focusedWorklogId=642796&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-642796
]
ASF GitHub Bot logged work on BEAM-11873:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/21 11:26
Start Date: 27/Aug/21 11:26
Worklog Time Spent: 10m
Work Description: AydarZaynutdinov edited a comment on pull request
#14856:
URL: https://github.com/apache/beam/pull/14856#issuecomment-907130750
Thanks @aromanenko-dev, @aaltay. As I understood I should:
- rename method withReturningResults() to withWriteResults().
- keep old method with name withResults() (do not rename it to
withVoidResults).
- change back private to public access for writeVoid method.
About other discussions:
- [records by
batches](https://github.com/apache/beam/pull/14856#discussion_r644967332).
Seems like Vitaliy explained why there is an execute() method instead of
executeBatch(). So I guess I should leave it like it is now -> use execute().
Is it right?
- [wrap up
`V`](https://github.com/apache/beam/pull/14856#discussion_r644964072). I'm not
sure that we need this wraping, because a new abstract class JdbcWriteResult
will have no any rules or parameters and as a result it would be just an empty
class. Maybe it would be better to transform JdbcWriteResult to empty
interface? So it would be like a marker for each`V`. Could you please share
your thoughts?
Is there anything else I should address?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 642796)
Time Spent: 4h 50m (was: 4h 40m)
> Add support for writes returning values
> ---------------------------------------
>
> Key: BEAM-11873
> URL: https://issues.apache.org/jira/browse/BEAM-11873
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
> Reporter: Maxim Ivanov
> Assignee: Vitaly Terentyev
> Priority: P3
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> SQL allows returning values from INSERT or UPDATE queries. It would be great
> if these values were returned from write operation and could be processed by
> further PTransforms
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
