[
https://issues.apache.org/jira/browse/BEAM-12100?focusedWorklogId=645534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-645534
]
ASF GitHub Bot logged work on BEAM-12100:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Sep/21 19:56
Start Date: 01/Sep/21 19:56
Worklog Time Spent: 10m
Work Description: benWize commented on pull request #15174:
URL: https://github.com/apache/beam/pull/15174#issuecomment-910668690
> There is one ZetaSQL compliance test failure. (ZetaSQL is mostly open
source but its compliance tests are not yet, so we usually end up duplicating
the tests in Beam where necessary.)
>
> It seems we are not handling this case properly: Returns NULL if the input
contains only NULLs. (from
https://github.com/google/zetasql/blob/master/docs/aggregate_functions.md#sum)
>
> Can you write a test for this case and fix it?
I added the test, and fix the null handling case, but I had to branch `SUM`
and `SUM0` logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 645534)
Time Spent: 7h 10m (was: 7h)
> SUM should error when overflow/underflow occurs.
> ------------------------------------------------
>
> Key: BEAM-12100
> URL: https://issues.apache.org/jira/browse/BEAM-12100
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> SELECT SUM(col1) FROM (SELECT CAST(9223372036854775807 as int64) as col1
> UNION ALL SELECT CAST(1 as int64))
> should return an error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
