[
https://issues.apache.org/jira/browse/BEAM-12100?focusedWorklogId=646540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646540
]
ASF GitHub Bot logged work on BEAM-12100:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/21 00:34
Start Date: 04/Sep/21 00:34
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #15174:
URL: https://github.com/apache/beam/pull/15174#discussion_r702208741
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamAggregationRel.java
##########
@@ -216,6 +216,8 @@ public RelWriter explainTerms(RelWriter pw) {
private WindowFn<Row, IntervalWindow> windowFn;
private int windowFieldIndex;
private List<FieldAggregation> fieldAggregations;
+ private final int groupSetCount;
+ private boolean ignoreValues;
Review comment:
Oops, I missed that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 646540)
Time Spent: 8h 40m (was: 8.5h)
> SUM should error when overflow/underflow occurs.
> ------------------------------------------------
>
> Key: BEAM-12100
> URL: https://issues.apache.org/jira/browse/BEAM-12100
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> SELECT SUM(col1) FROM (SELECT CAST(9223372036854775807 as int64) as col1
> UNION ALL SELECT CAST(1 as int64))
> should return an error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
