[
https://issues.apache.org/jira/browse/BEAM-11982?focusedWorklogId=649351&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649351
]
ASF GitHub Bot logged work on BEAM-11982:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/21 17:50
Start Date: 10/Sep/21 17:50
Worklog Time Spent: 10m
Work Description: benWize commented on pull request #15493:
URL: https://github.com/apache/beam/pull/15493#issuecomment-917095479
@ajamato Would you help me to review the progress on this? It is still
pending to add `queryName` as label metrics, but I want to ask your opinion
about it.
I added `queryName` to `ReadOperation` Builder
https://github.com/apache/beam/blob/63c07230d50eb7335a2518fcda712fccc4646278/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/ReadOperation.java#L99
but at this point the `ReadOperation` is not accessible, only `Transaction`
https://github.com/apache/beam/blob/63c07230d50eb7335a2518fcda712fccc4646278/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java#L161
My suggested approach is to add queryName to `CreateTransaction` Builder so
I can extract queryName inside `ReadFromPartitionFn` process method
https://github.com/apache/beam/blob/63c07230d50eb7335a2518fcda712fccc4646278/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java#L753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 649351)
Time Spent: 20m (was: 10m)
> Java Spanner - Implement IO Request Count metrics
> -------------------------------------------------
>
> Key: BEAM-11982
> URL: https://issues.apache.org/jira/browse/BEAM-11982
> Project: Beam
> Issue Type: Test
> Components: io-java-gcp
> Reporter: Alex Amato
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Reference PRs (See BigQuery IO example) and detailed explanation of what's
> needed to instrument this IO with Request Count metrics is found in this
> handoff doc:
> [https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'|https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'?authuser=0]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
