[
https://issues.apache.org/jira/browse/BEAM-11982?focusedWorklogId=653802&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-653802
]
ASF GitHub Bot logged work on BEAM-11982:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/21 20:37
Start Date: 21/Sep/21 20:37
Worklog Time Spent: 10m
Work Description: ajamato commented on a change in pull request #15493:
URL: https://github.com/apache/beam/pull/15493#discussion_r713393015
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java
##########
@@ -18,12 +18,12 @@
package org.apache.beam.sdk.io.gcp.spanner;
import com.google.auto.value.AutoValue;
-import com.google.cloud.spanner.BatchReadOnlyTransaction;
-import com.google.cloud.spanner.Partition;
-import com.google.cloud.spanner.ResultSet;
-import com.google.cloud.spanner.Struct;
-import com.google.cloud.spanner.TimestampBound;
+import com.google.cloud.spanner.*;
Review comment:
Could you run ./gradlew spotlessApply ?
I think the preferred style is to avoid wildcard imports
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOReadTest.java
##########
@@ -17,33 +17,29 @@
*/
package org.apache.beam.sdk.io.gcp.spanner;
+import static org.junit.Assert.assertEquals;
import static org.mockito.Matchers.any;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.when;
import com.google.cloud.Timestamp;
-import com.google.cloud.spanner.BatchReadOnlyTransaction;
-import com.google.cloud.spanner.BatchTransactionId;
-import com.google.cloud.spanner.FakeBatchTransactionId;
-import com.google.cloud.spanner.FakePartitionFactory;
-import com.google.cloud.spanner.KeySet;
-import com.google.cloud.spanner.Partition;
-import com.google.cloud.spanner.PartitionOptions;
-import com.google.cloud.spanner.ResultSets;
-import com.google.cloud.spanner.Statement;
-import com.google.cloud.spanner.Struct;
-import com.google.cloud.spanner.TimestampBound;
-import com.google.cloud.spanner.Type;
-import com.google.cloud.spanner.Value;
+import com.google.cloud.spanner.*;
Review comment:
ditto, wildcard imports
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
##########
@@ -40,12 +40,11 @@
import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Comparator;
-import java.util.List;
-import java.util.OptionalInt;
+import java.util.*;
Review comment:
ditto, wildcard imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 653802)
Time Spent: 1.5h (was: 1h 20m)
> Java Spanner - Implement IO Request Count metrics
> -------------------------------------------------
>
> Key: BEAM-11982
> URL: https://issues.apache.org/jira/browse/BEAM-11982
> Project: Beam
> Issue Type: Test
> Components: io-java-gcp
> Reporter: Alex Amato
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Reference PRs (See BigQuery IO example) and detailed explanation of what's
> needed to instrument this IO with Request Count metrics is found in this
> handoff doc:
> [https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'|https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'?authuser=0]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
