[
https://issues.apache.org/jira/browse/BEAM-6747?focusedWorklogId=211922&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-211922
]
ASF GitHub Bot logged work on BEAM-6747:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/19 18:13
Start Date: 12/Mar/19 18:13
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #7954: [BEAM-6747] Adding
ExternalTransform in JavaSDK
URL: https://github.com/apache/beam/pull/7954#discussion_r264812364
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ExternalTranslation.java
##########
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.core.construction;
+
+import static
org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkArgument;
+import static
org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkState;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Map;
+import javax.annotation.Nullable;
+import org.apache.beam.model.pipeline.v1.RunnerApi;
+import org.apache.beam.sdk.runners.AppliedPTransform;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.values.PCollection;
+import org.apache.beam.sdk.values.PValue;
+import
org.apache.beam.vendor.guava.v20_0.com.google.common.collect.ImmutableMap;
+
+/** Translating External transforms to proto. */
+public class ExternalTranslation {
+ public static final String EXTERNAL_TRANSFORM_URN =
"urn:beam:transform:external:v1";
+
+ /** Translator for ExpandableTransform. */
+ public static class ExternalTranslator
+ implements
PTransformTranslation.TransformTranslator<External.ExpandableTransform<?>> {
+ public static PTransformTranslation.TransformTranslator create() {
+ return new ExternalTranslator();
+ }
+
+ @Nullable
+ @Override
+ public String getUrn(External.ExpandableTransform transform) {
+ return EXTERNAL_TRANSFORM_URN;
+ }
+
+ @Override
+ public boolean canTranslate(PTransform<?, ?> pTransform) {
+ return pTransform instanceof External.ExpandableTransform;
+ }
+
+ @Override
+ public RunnerApi.PTransform translate(
+ AppliedPTransform<?, ?, ?> appliedPTransform,
+ List<AppliedPTransform<?, ?, ?>> subtransforms,
+ SdkComponents components)
+ throws IOException {
+ checkArgument(
+ canTranslate(appliedPTransform.getTransform()), "can only translate
ExpandableTransform");
+
+ External.ExpandableTransform expandableTransform =
+ (External.ExpandableTransform) appliedPTransform.getTransform();
+ String nameSpace = expandableTransform.getNamespace();
+ String impulsePrefix = expandableTransform.getImpulsePrefix();
+ ImmutableMap.Builder<String, String> pColRenameMapBuilder =
ImmutableMap.builder();
+ RunnerApi.PTransform expandedTransform =
expandableTransform.getExpandedTransform();
+ RunnerApi.Components expandedComponents =
expandableTransform.getExpandedComponents();
+ Map<PCollection, String> externalPCollectionIdMap =
+ expandableTransform.getExternalPCollectionIdMap();
+
+ for (PValue pcol : appliedPTransform.getInputs().values()) {
+ if (!(pcol instanceof PCollection)) {
+ throw new RuntimeException("unknown input type.");
+ }
+ pColRenameMapBuilder.put(
+ externalPCollectionIdMap.get(pcol),
components.registerPCollection((PCollection) pcol));
+ }
+ for (PValue pcol : appliedPTransform.getOutputs().values()) {
+ if (!(pcol instanceof PCollection)) {
+ throw new RuntimeException("unknown input type.");
+ }
+ pColRenameMapBuilder.put(
+ externalPCollectionIdMap.get(pcol),
components.registerPCollection((PCollection) pcol));
+ }
+
+ ImmutableMap<String, String> pColRenameMap =
pColRenameMapBuilder.build();
+ RunnerApi.Components.Builder mergingComponentsBuilder =
RunnerApi.Components.newBuilder();
+ for (Map.Entry<String, RunnerApi.Coder> entry :
+ expandedComponents.getCodersMap().entrySet()) {
+ if (entry.getKey().startsWith(nameSpace)) {
+ mergingComponentsBuilder.putCoders(entry.getKey(), entry.getValue());
+ }
+ }
+ for (Map.Entry<String, RunnerApi.WindowingStrategy> entry :
+ expandedComponents.getWindowingStrategiesMap().entrySet()) {
+ if (entry.getKey().startsWith(nameSpace)) {
+ mergingComponentsBuilder.putWindowingStrategies(entry.getKey(),
entry.getValue());
+ }
+ }
+ for (Map.Entry<String, RunnerApi.Environment> entry :
+ expandedComponents.getEnvironmentsMap().entrySet()) {
+ if (entry.getKey().startsWith(nameSpace)) {
+ mergingComponentsBuilder.putEnvironments(entry.getKey(),
entry.getValue());
+ }
+ }
+ for (Map.Entry<String, RunnerApi.PCollection> entry :
+ expandedComponents.getPcollectionsMap().entrySet()) {
+ if (entry.getKey().startsWith(nameSpace)) {
+ mergingComponentsBuilder.putPcollections(entry.getKey(),
entry.getValue());
+ }
+ }
+ for (Map.Entry<String, RunnerApi.PTransform> entry :
+ expandedComponents.getTransformsMap().entrySet()) {
+ if (entry.getKey().startsWith(impulsePrefix)) {
+ continue;
Review comment:
Please add a comment here why this is necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 211922)
Time Spent: 1h 50m (was: 1h 40m)
> Adding ExternalTransform in JavaSDK
> -----------------------------------
>
> Key: BEAM-6747
> URL: https://issues.apache.org/jira/browse/BEAM-6747
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Adding Java counterpart of Python ExternalTransform for testing Python
> transforms from pipelines in Java SDK.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
