[
https://issues.apache.org/jira/browse/BEAM-12883?focusedWorklogId=655860&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-655860
]
ASF GitHub Bot logged work on BEAM-12883:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/21 22:47
Start Date: 27/Sep/21 22:47
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #15510:
URL: https://github.com/apache/beam/pull/15510#issuecomment-928390587
I think the only way to preserver backwards compatibility here is to add a
new coder and also add an opt-in mechanism for users to select this new coder.
It may be worth considering making this coder more extensible so this doesn't
happen in the future (e.g. storing the values as a key-value map and ignoring
unknown fields, which is less efficient but probably doesn't matter for this
coder vs. the chances that we'll want to add a new field in the future.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 655860)
Time Spent: 50m (was: 40m)
> FileSystems ReadableFileCoder should support Metadata#lastModifiedMillis()
> --------------------------------------------------------------------------
>
> Key: BEAM-12883
> URL: https://issues.apache.org/jira/browse/BEAM-12883
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Brachi Packter
> Priority: P3
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently, there is a separated coder for Metadata which cares about
> `Metadata#lastModifiedMillis()`.
> The issue is that the `ReadableFileCoder` always uses the default `Metadata`
> coder.
> We need to create a similar coder for `ReadableFileCoder`:
> ``ReadableFileCoderV2` which just use the corresponding `MetadataCoderV2`.
> Without doing so `lastModifiedMillis` will remain zero.
> There is also no way to create custom coder in our side since
> `FileIO.ReadableFile` has no public method to initiate new instance of it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
