[
https://issues.apache.org/jira/browse/BEAM-12883?focusedWorklogId=657474&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657474
]
ASF GitHub Bot logged work on BEAM-12883:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/21 18:59
Start Date: 29/Sep/21 18:59
Worklog Time Spent: 10m
Work Description: brachi-wernick commented on pull request #15510:
URL: https://github.com/apache/beam/pull/15510#issuecomment-930457576
Creating more extendable coder is definitely better, I would suggest the
bellow:
1. Add `MetadataCoder` the ability to get list of fields names needed to be
encoded/decode.
2. `ReadableFileCoder` will get `MetadataCoder` instance in its constructor
parameters. to make the configuration and adjustments only in one
place(`MetadataCoder`)
We can make this also in 2 phases-PRs, (start with number 2 just to solve
the current issue and then enhance MetadataCoder for next future fields)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 657474)
Time Spent: 1h 10m (was: 1h)
> FileSystems ReadableFileCoder should support Metadata#lastModifiedMillis()
> --------------------------------------------------------------------------
>
> Key: BEAM-12883
> URL: https://issues.apache.org/jira/browse/BEAM-12883
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Brachi Packter
> Priority: P3
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently, there is a separated coder for Metadata which cares about
> `Metadata#lastModifiedMillis()`.
> The issue is that the `ReadableFileCoder` always uses the default `Metadata`
> coder.
> We need to create a similar coder for `ReadableFileCoder`:
> ``ReadableFileCoderV2` which just use the corresponding `MetadataCoderV2`.
> Without doing so `lastModifiedMillis` will remain zero.
> There is also no way to create custom coder in our side since
> `FileIO.ReadableFile` has no public method to initiate new instance of it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
