[ 
https://issues.apache.org/jira/browse/BEAM-12849?focusedWorklogId=657184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657184
 ]

ASF GitHub Bot logged work on BEAM-12849:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Sep/21 12:20
            Start Date: 29/Sep/21 12:20
    Worklog Time Spent: 10m 
      Work Description: aromanenko-dev commented on a change in pull request 
#15529:
URL: https://github.com/apache/beam/pull/15529#discussion_r718451640



##########
File path: runners/spark/spark_runner.gradle
##########
@@ -166,6 +166,10 @@ dependencies {
   provided 
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
   provided "org.apache.spark:spark-sql_$spark_scala_version:$spark_version"
   provided 
"org.apache.spark:spark-streaming_$spark_scala_version:$spark_version"
+  runtimeOnly "org.apache.spark:spark-core_$spark_scala_version:$spark_version"

Review comment:
       1. Why do we need to have two configurations (`provided` and 
`runtimeOnly`) for the same deps?
   2. Can you make sure that generated jars won't cause breaking changes for 
users who already use any of Spark Runners?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 657184)
    Time Spent: 1h 40m  (was: 1.5h)

> Structured Streaming runner: Migrate metrics sources
> ----------------------------------------------------
>
>                 Key: BEAM-12849
>                 URL: https://issues.apache.org/jira/browse/BEAM-12849
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-spark
>            Reporter: Etienne Chauchot
>            Priority: P2
>              Labels: structured-streaming
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> java.lang.ClassNotFoundException: org.apache.spark.metrics.source.Source no 
> more exists in spark 3.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to