[ 
https://issues.apache.org/jira/browse/BEAM-12849?focusedWorklogId=658131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658131
 ]

ASF GitHub Bot logged work on BEAM-12849:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Sep/21 07:22
            Start Date: 30/Sep/21 07:22
    Worklog Time Spent: 10m 
      Work Description: echauchot commented on a change in pull request #15529:
URL: https://github.com/apache/beam/pull/15529#discussion_r719127681



##########
File path: runners/spark/spark_runner.gradle
##########
@@ -166,6 +166,10 @@ dependencies {
   provided 
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
   provided "org.apache.spark:spark-sql_$spark_scala_version:$spark_version"
   provided 
"org.apache.spark:spark-streaming_$spark_scala_version:$spark_version"
+  runtimeOnly "org.apache.spark:spark-core_$spark_scala_version:$spark_version"

Review comment:
       > Note that `provided` is used when generating the pom.xml for this 
artifact to list a provided dependency.
   
   I also took a look at the generated poms (thanks Alexey for the ping about 
that) and they are exactly identical to the ones before the change for both 
spark 2 and spark 3 modules. Meaning that they contain apache spark libs in 
provided scope as before.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 658131)
    Time Spent: 2h 50m  (was: 2h 40m)

> Structured Streaming runner: Migrate metrics sources
> ----------------------------------------------------
>
>                 Key: BEAM-12849
>                 URL: https://issues.apache.org/jira/browse/BEAM-12849
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-spark
>            Reporter: Etienne Chauchot
>            Priority: P2
>              Labels: structured-streaming
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> java.lang.ClassNotFoundException: org.apache.spark.metrics.source.Source no 
> more exists in spark 3.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to