[
https://issues.apache.org/jira/browse/BEAM-12931?focusedWorklogId=658652&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658652
]
ASF GitHub Bot logged work on BEAM-12931:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/21 23:09
Start Date: 30/Sep/21 23:09
Worklog Time Spent: 10m
Work Description: laraschmidt commented on a change in pull request
#15540:
URL: https://github.com/apache/beam/pull/15540#discussion_r719830252
##########
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/FnApiDoFnRunnerTest.java
##########
@@ -1604,6 +1606,11 @@ public ProcessContinuation processElement(
}
}
+ @Override
+ public Duration getAllowedTimestampSkew() {
Review comment:
This test was triggering the check. I believe because it outputs
timestamps at a given position past the min timestamp which seemed sufficiently
weird / hacky that I'm not surprised it was triggering it. Hard to tell for
sure but I don't believe the tests using this DoFn set timestamp on the input
records at all so not surprising that the new output timestamp is less than the
actual timestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 658652)
Time Spent: 2h 20m (was: 2h 10m)
> Timer.setOutputTimestamp doesn't take into account for
> DoFn#getAllowedTimestampSkew()
> -------------------------------------------------------------------------------------
>
> Key: BEAM-12931
> URL: https://issues.apache.org/jira/browse/BEAM-12931
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Lara Schmidt
> Assignee: Lara Schmidt
> Priority: P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> A DoFn may emit elements with a timestamp up to
> DoFn#getAllowedTimestampSkew() before the current element's timestamp.
> However getAllowedTimestampSkew is not properly accounted for in looking at
> the output timestamp of a timer.
> Context:
> [https://lists.apache.org/thread.html/r7554658114ddde86c5d82e1c39fe7e1ef587fe926b8e406d1130d501%40%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
