[ 
https://issues.apache.org/jira/browse/BEAM-12849?focusedWorklogId=658812&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658812
 ]

ASF GitHub Bot logged work on BEAM-12849:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Oct/21 08:19
            Start Date: 01/Oct/21 08:19
    Worklog Time Spent: 10m 
      Work Description: echauchot commented on pull request #15529:
URL: https://github.com/apache/beam/pull/15529#issuecomment-932023808


   > It would make a lot more sense to repeat the existing pattern where we add 
the necessary deps to the nexmark run as we do for spark 2 with 
`shouldProvideSpark`:
   > 
   > 
https://github.com/apache/beam/blob/e5ac1ae1c0ba1a682b2ace4ebdae8e4a1b5f8716/sdks/java/testing/nexmark/build.gradle#L41
   > 
   > 
   > and add the deps here:
   > 
https://github.com/apache/beam/blob/e5ac1ae1c0ba1a682b2ace4ebdae8e4a1b5f8716/sdks/java/testing/nexmark/build.gradle#L96
   > 
   > 
   > since this change is about running nexmark on spark.
   > This will keep the same pattern used in nexmark and other integration 
tests.
   
   Thanks @lukecwik for the suggestion ! I totally agree, I was just not aware 
of this part of the conf !
   If in the future it is needed for somewhere else than Nexmark, we will use 
the same pattern again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 658812)
    Time Spent: 3h 50m  (was: 3h 40m)

> Structured Streaming runner: Migrate metrics sources
> ----------------------------------------------------
>
>                 Key: BEAM-12849
>                 URL: https://issues.apache.org/jira/browse/BEAM-12849
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-spark
>            Reporter: Etienne Chauchot
>            Assignee: Etienne Chauchot
>            Priority: P2
>              Labels: structured-streaming
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> java.lang.ClassNotFoundException: org.apache.spark.metrics.source.Source no 
> more exists in spark 3.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to