[
https://issues.apache.org/jira/browse/BEAM-12999?focusedWorklogId=662587&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-662587
]
ASF GitHub Bot logged work on BEAM-12999:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/21 08:09
Start Date: 08/Oct/21 08:09
Worklog Time Spent: 10m
Work Description: je-ik commented on a change in pull request #15665:
URL: https://github.com/apache/beam/pull/15665#discussion_r724787671
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingTransformTranslators.java
##########
@@ -159,6 +159,8 @@
new CreateViewStreamingTranslator());
TRANSLATORS.put(PTransformTranslation.RESHUFFLE_URN, new
ReshuffleTranslatorStreaming());
Review comment:
Here as well, do we still match this?
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ReshuffleTranslation.java
##########
@@ -36,26 +36,43 @@
})
public class ReshuffleTranslation {
- static class ReshuffleTranslator implements
TransformPayloadTranslator<Reshuffle<?, ?>> {
Review comment:
This looks like a breaking change. Runners that are released
independently from Beam releases (e.g. IBM streams?) might have translation for
the original URN and these will not be changed. Could we keep this URN
available and let the runner expand it, if it uses the new URNs?
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchPortablePipelineTranslator.java
##########
@@ -153,6 +153,9 @@ public static FlinkBatchPortablePipelineTranslator
createTranslator() {
translatorMap.put(
PTransformTranslation.RESHUFFLE_URN,
FlinkBatchPortablePipelineTranslator::translateReshuffle);
Review comment:
Hm, if we removed the `ReshuffleTranslator`, this will not be matched
(when produced by the Java SDK), right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 662587)
Time Spent: 3h 50m (was: 3h 40m)
> Improve Reshuffle Transform
> ---------------------------
>
> Key: BEAM-12999
> URL: https://issues.apache.org/jira/browse/BEAM-12999
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go, sdk-java-core, sdk-py-core
> Reporter: Ke Wu
> Assignee: Ke Wu
> Priority: P2
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> See discussion
> [https://lists.apache.org/thread.html/r83adaad3a512ad186f2f9dc9dc4bec2a789070677c07cdcaad6fcfa5%40%3Cdev.beam.apache.org%3E]
>
>
> “beam:transform:reshuffle:v1" Transform represents different semantic
> transforms in different SDKs. The proposal is to replace
> "beam:transform:reshuffle:v1" with two new urns, one to represent reshuffle
> KV PCollection using the K, and the other to reshuffle based on random key.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
