[
https://issues.apache.org/jira/browse/BEAM-12999?focusedWorklogId=662829&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-662829
]
ASF GitHub Bot logged work on BEAM-12999:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/21 16:22
Start Date: 08/Oct/21 16:22
Worklog Time Spent: 10m
Work Description: kw2542 commented on a change in pull request #15665:
URL: https://github.com/apache/beam/pull/15665#discussion_r725147283
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ReshuffleTranslation.java
##########
@@ -36,26 +36,43 @@
})
public class ReshuffleTranslation {
- static class ReshuffleTranslator implements
TransformPayloadTranslator<Reshuffle<?, ?>> {
Review comment:
correct me if I am wrong, the registrar here is only used when
converting a Java SDK Pipeline to Portable/Protobuf Pipeline.
Since we have already updated Reshuffle.of() to return Reshuffle.PerKey
which is a PTransform with the new Urn, it should be relatively safe to remove.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 662829)
Time Spent: 4h 20m (was: 4h 10m)
> Improve Reshuffle Transform
> ---------------------------
>
> Key: BEAM-12999
> URL: https://issues.apache.org/jira/browse/BEAM-12999
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go, sdk-java-core, sdk-py-core
> Reporter: Ke Wu
> Assignee: Ke Wu
> Priority: P2
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> See discussion
> [https://lists.apache.org/thread.html/r83adaad3a512ad186f2f9dc9dc4bec2a789070677c07cdcaad6fcfa5%40%3Cdev.beam.apache.org%3E]
>
>
> “beam:transform:reshuffle:v1" Transform represents different semantic
> transforms in different SDKs. The proposal is to replace
> "beam:transform:reshuffle:v1" with two new urns, one to represent reshuffle
> KV PCollection using the K, and the other to reshuffle based on random key.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
