[
https://issues.apache.org/jira/browse/BEAM-12999?focusedWorklogId=663635&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663635
]
ASF GitHub Bot logged work on BEAM-12999:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/21 16:24
Start Date: 11/Oct/21 16:24
Worklog Time Spent: 10m
Work Description: je-ik commented on a change in pull request #15665:
URL: https://github.com/apache/beam/pull/15665#discussion_r726296511
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ReshuffleTranslation.java
##########
@@ -36,26 +36,43 @@
})
public class ReshuffleTranslation {
- static class ReshuffleTranslator implements
TransformPayloadTranslator<Reshuffle<?, ?>> {
Review comment:
Could we expand `Reshuffle.of()` into `Reshuffle.perKey()`? I'd remove
the URN for Reshuffle.of() once we remove the deprecated Reshuffle.of() method.
If we directly expand Reshuffle.of() into Reshuffle.perKey(), then I think
it would be possible to test the expansion and then replace all the occurrences
of Reshuffle.of() by Reshuffle.perKey().
@robertwb WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 663635)
Time Spent: 7h 20m (was: 7h 10m)
> Improve Reshuffle Transform
> ---------------------------
>
> Key: BEAM-12999
> URL: https://issues.apache.org/jira/browse/BEAM-12999
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go, sdk-java-core, sdk-py-core
> Reporter: Ke Wu
> Assignee: Ke Wu
> Priority: P2
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> See discussion
> [https://lists.apache.org/thread.html/r83adaad3a512ad186f2f9dc9dc4bec2a789070677c07cdcaad6fcfa5%40%3Cdev.beam.apache.org%3E]
>
>
> “beam:transform:reshuffle:v1" Transform represents different semantic
> transforms in different SDKs. The proposal is to replace
> "beam:transform:reshuffle:v1" with two new urns, one to represent reshuffle
> KV PCollection using the K, and the other to reshuffle based on random key.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
