[ 
https://issues.apache.org/jira/browse/BEAM-13013?focusedWorklogId=663733&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663733
 ]

ASF GitHub Bot logged work on BEAM-13013:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Oct/21 19:18
            Start Date: 11/Oct/21 19:18
    Worklog Time Spent: 10m 
      Work Description: htyleo edited a comment on pull request #15698:
URL: https://github.com/apache/beam/pull/15698#issuecomment-940370691


   Thanks for working on this extension!
   
   It does seem cleaner to consolidate the methods on HandlerParams. For SQL 
implementation, what we actually need are:
   1) input names + types (ExternalTransform.InputsMap + MultiEdge.Input.Type)
   2) output type (ExternalTransform.OutputsMap + MultiEdge.Output.Type)
   3) payload (ExternalTransform.Payload)
   
   Other HandlerParams info (windowing strategy, coder, etc) are used to 
properly construct the resulting Components and Transform in ExpansionResponse. 
If we can come up with some helper functions/methods, we may not need to expose 
them and can make user's life easier.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 663733)
    Time Spent: 1h 10m  (was: 1h)

> Extend expansion service handling to allow overrides/conveniences.
> ------------------------------------------------------------------
>
>                 Key: BEAM-13013
>                 URL: https://issues.apache.org/jira/browse/BEAM-13013
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Robert Burke
>            Assignee: Robert Burke
>            Priority: P2
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Described in the BeamSQL for the Go SDK document: 
> https://s.apache.org/beam-go-sql-api



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to