[
https://issues.apache.org/jira/browse/BEAM-13001?focusedWorklogId=663768&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663768
]
ASF GitHub Bot logged work on BEAM-13001:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/21 21:00
Start Date: 11/Oct/21 21:00
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #15657:
URL: https://github.com/apache/beam/pull/15657#issuecomment-940436100
Taking a look, but before I start.
> PTAL. Addressed the old comments. However, I didn't understand clearly,
the approach of initializing sampler in exec.Pardo's Up method.
I think what I meant could be more clearly said. Instead of "sampler" which
is very overloaded, I should have said "state switcher" which tells the
underlying metric the current state & PTransform. Basically it could have 3
methods (Start, Process, Finish) which switch the state to the current enum
(start process finish), and then do an atomic store with the state. This avoids
allocating a new state every time these are called, and avoids any race
conditions with the reading sampler goroutine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 663768)
Time Spent: 1h 20m (was: 1h 10m)
> DoFn Execution time metrics (msecs) for Go SDK
> ----------------------------------------------
>
> Key: BEAM-13001
> URL: https://issues.apache.org/jira/browse/BEAM-13001
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Ritesh Ghorse
> Assignee: Ritesh Ghorse
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Implement DoFn execution time metrics for Go SDK.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
