[ 
https://issues.apache.org/jira/browse/BEAM-13001?focusedWorklogId=666414&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-666414
 ]

ASF GitHub Bot logged work on BEAM-13001:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Oct/21 16:39
            Start Date: 18/Oct/21 16:39
    Worklog Time Spent: 10m 
      Work Description: riteshghorse commented on pull request #15657:
URL: https://github.com/apache/beam/pull/15657#issuecomment-945959699


   PTAL. The second test works as expected.
   
   The precommit here is failing in the `metrics_test`.  When we do the metrics 
dump we expected only the counter values earlier. But now the addition of 
[MsecsInt64](https://github.com/apache/beam/blob/57c81d7aedb1c334fa17dc399bd75af808ed8901/sdks/go/pkg/beam/core/metrics/store.go#L97)
 to the 
[Extractor](https://github.com/apache/beam/blob/57c81d7aedb1c334fa17dc399bd75af808ed8901/sdks/go/pkg/beam/core/metrics/store.go#L89)
 will dump execution state metric value as well and the test fails.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 666414)
    Time Spent: 2h 20m  (was: 2h 10m)

> DoFn Execution time metrics (msecs) for Go SDK
> ----------------------------------------------
>
>                 Key: BEAM-13001
>                 URL: https://issues.apache.org/jira/browse/BEAM-13001
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Ritesh Ghorse
>            Assignee: Ritesh Ghorse
>            Priority: P2
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Implement DoFn execution time metrics for Go SDK. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to