[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=665311&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665311
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Oct/21 19:20
Start Date: 13/Oct/21 19:20
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#15648:
URL: https://github.com/apache/beam/pull/15648#discussion_r728372285
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java
##########
@@ -163,11 +163,6 @@
return new
AutoValue_HL7v2IO_Write.Builder().setHL7v2Store(StaticValueProvider.of(hl7v2Store));
}
- /** Write HL7v2 Messages to a store. */
- private static Write.Builder write(ValueProvider<String> hl7v2Store) {
- return new AutoValue_HL7v2IO_Write.Builder().setHL7v2Store(hl7v2Store);
- }
Review comment:
I think it's possible some of these functions were intended to be
public, but given that they're not tested (otherwise they would be used), and
no one has asked about them, I agree with the decision to go ahead and delete
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 665311)
Time Spent: 6h 20m (was: 6h 10m)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
