[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=665463&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665463
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/21 00:34
Start Date: 14/Oct/21 00:34
Worklog Time Spent: 10m
Work Description: benWize commented on a change in pull request #15648:
URL: https://github.com/apache/beam/pull/15648#discussion_r728541561
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/coders/BigDecimalCoderTest.java
##########
@@ -39,6 +39,7 @@
private static final Coder<BigDecimal> TEST_CODER = BigDecimalCoder.of();
+ @SuppressWarnings("BigDecimalLiteralDouble")
Review comment:
This test
https://github.com/apache/beam/blob/6563caf3d83af2a18a8a1d306ae378d46cf17023/sdks/java/core/src/test/java/org/apache/beam/sdk/coders/BigDecimalCoderTest.java#L92
failed with the suggested change.
I've changed the expected string so the test still succeeds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 665463)
Time Spent: 7h 10m (was: 7h)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
