[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=670985&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-670985
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Oct/21 19:35
Start Date: 27/Oct/21 19:35
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#15742:
URL: https://github.com/apache/beam/pull/15742#discussion_r737770860
##########
File path:
examples/java/src/main/java/org/apache/beam/examples/subprocess/ExampleEchoPipeline.java
##########
@@ -44,6 +44,7 @@
* SubProcessPipelineOptions}
*/
public class ExampleEchoPipeline {
+ @SuppressWarnings("unused")
private static final Logger LOG =
LoggerFactory.getLogger(ExampleEchoPipeline.class);
Review comment:
If this logger isn't used let's just remove it (same comment in other
places like this).
##########
File path:
examples/kotlin/src/main/java/org/apache/beam/examples/kotlin/cookbook/DistinctExample.kt
##########
@@ -71,8 +71,6 @@ object DistinctExample {
override fun create(options: PipelineOptions): String {
options.tempLocation.let {
return
GcsPath.fromUri(it).resolve("deduped.txt").toString()
- } ?: run {
- throw IllegalArgumentException("Must specify --output or
--tempLocation")
Review comment:
Is this something that errorprone caught? I didn't think it checked
kotlin files
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/External.java
##########
@@ -314,6 +314,7 @@ public OutputT expand(InputT input) {
.addAllArtifacts(artifacts)
.build())
.getReplacementsList()) {
+ @SuppressWarnings("unused")
RunnerApi.ArtifactInformation.Builder newArtifact =
artifact.toBuilder();
Review comment:
we should just remove this
##########
File path:
examples/java/src/test/java/org/apache/beam/examples/complete/datatokenization/DataTokenizationTest.java
##########
@@ -137,7 +137,7 @@ public void testFileSystemIOReadJSON() throws IOException {
@Test
public void testJsonToRow() throws IOException {
PCollection<Row> rows = fileSystemIORead(JSON_FILE_PATH, FORMAT.JSON);
- SchemasUtils testSchemaUtils = new SchemasUtils(SCHEMA_FILE_PATH,
StandardCharsets.UTF_8);
+ new SchemasUtils(SCHEMA_FILE_PATH, StandardCharsets.UTF_8);
Review comment:
Do we need to construct this for some side effect? Or can we just remove
the line entirely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 670985)
Time Spent: 12h 50m (was: 12h 40m)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
