[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=672200&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-672200
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/21 21:02
Start Date: 29/Oct/21 21:02
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#15821:
URL: https://github.com/apache/beam/pull/15821#discussion_r739513205
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnInvokersTest.java
##########
@@ -92,6 +92,7 @@
@RunWith(JUnit4.class)
@SuppressWarnings({
"rawtypes", // TODO(https://issues.apache.org/jira/browse/BEAM-10556)
+ "SameNameButDifferent"
Review comment:
Here as well
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/transforms/GroupTest.java
##########
@@ -70,6 +70,7 @@
@Category(UsesSchema.class)
@SuppressWarnings({
"rawtypes", // TODO(https://issues.apache.org/jira/browse/BEAM-10556)
+ "SameNameButDifferent"
Review comment:
Why not fix this one?
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/ProcessRemoteBundleOperation.java
##########
@@ -54,13 +54,16 @@
private final StageBundleFactory stageBundleFactory;
private static final OutputReceiver[] EMPTY_RECEIVER_ARRAY = new
OutputReceiver[0];
private final Map<String, OutputReceiver> outputReceiverMap;
+
+ @SuppressWarnings("UnnecessaryAnonymousClass")
Review comment:
I was going to request we go ahead and resolve these, but I'm not really
clear on how to do it. It seems like we'd need to do some refactoring. So I
think this is fine for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 672200)
Time Spent: 14h 20m (was: 14h 10m)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 14h 20m
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
