[
https://issues.apache.org/jira/browse/BEAM-13099?focusedWorklogId=673947&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-673947
]
ASF GitHub Bot logged work on BEAM-13099:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Nov/21 21:23
Start Date: 02/Nov/21 21:23
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#15836:
URL: https://github.com/apache/beam/pull/15836#discussion_r741449798
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -53,10 +53,12 @@ def hadoopVersions = [
hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
dependencies {
+ // Required for processing Calcite's immutable annotations
Review comment:
Yeah, to be honest I don't quite understand why this is necessary.
Without this we get this error during annotation processing:
```
error: cannot access Value
class file for org.immutables.value.Value not found
```
and then a series of errors due to missing AutoValue-generated classes like:
```
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/TableName.java:73:
error: cannot find symbol
return new AutoValue_TableName(path == null ? Collections.emptyList() :
path, tableName);
^
symbol: class AutoValue_TableName
location: class TableName
```
Perhaps this is a bad interaction with another annotation processor?
I'm also inclined to just not worry about this, but I'm a little nervous
we'll inflict the same annotation processing issue on our users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 673947)
Time Spent: 10.5h (was: 10h 20m)
> Upgrade vendored Calcite to 1.28.0
> ----------------------------------
>
> Key: BEAM-13099
> URL: https://issues.apache.org/jira/browse/BEAM-13099
> Project: Beam
> Issue Type: Task
> Components: dsl-sql, dsl-sql-zetasql
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Currently we are using a vendored 1.26.0 calcite, and 1.28.0 was just
> released:
> https://lists.apache.org/thread.html/rf1ec7754af0dc8ca57f8a2c7211ab47a7e950c6a4588801638f22f43%40%3Cdev.calcite.apache.org%3E
> We should try upgrading to 1.28.0. We can consider just updating to 1.27.0 if
> there are blockers in 1.28.0 not present in 1.27.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
