[
https://issues.apache.org/jira/browse/BEAM-13099?focusedWorklogId=675271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675271
]
ASF GitHub Bot logged work on BEAM-13099:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 00:35
Start Date: 04/Nov/21 00:35
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #15836:
URL: https://github.com/apache/beam/pull/15836#discussion_r742104648
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -53,10 +53,12 @@ def hadoopVersions = [
hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
dependencies {
+ // Required for processing Calcite's immutable annotations
Review comment:
If its only necessary for annotation processing consider adding it under
`annotationProcessor` and possibly `compileOnly` (only if its a dep as well)
like
[BeamModulePlugin.groovy](https://github.com/apache/beam/blob/48318dd3aedeb208648149eca36165bbfff09e1a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L966)
does.
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -53,10 +53,12 @@ def hadoopVersions = [
hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
dependencies {
+ // Required for processing Calcite's immutable annotations
Review comment:
If its only necessary for annotation processing consider adding it under
`annotationProcessor` and possibly `compileOnly` (only if its a dep as well)
like
[BeamModulePlugin.groovy](https://github.com/apache/beam/blob/48318dd3aedeb208648149eca36165bbfff09e1a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L966)
does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 675271)
Time Spent: 12h 10m (was: 12h)
> Upgrade vendored Calcite to 1.28.0
> ----------------------------------
>
> Key: BEAM-13099
> URL: https://issues.apache.org/jira/browse/BEAM-13099
> Project: Beam
> Issue Type: Task
> Components: dsl-sql, dsl-sql-zetasql
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 12h 10m
> Remaining Estimate: 0h
>
> Currently we are using a vendored 1.26.0 calcite, and 1.28.0 was just
> released:
> https://lists.apache.org/thread.html/rf1ec7754af0dc8ca57f8a2c7211ab47a7e950c6a4588801638f22f43%40%3Cdev.calcite.apache.org%3E
> We should try upgrading to 1.28.0. We can consider just updating to 1.27.0 if
> there are blockers in 1.28.0 not present in 1.27.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
