[
https://issues.apache.org/jira/browse/BEAM-11217?focusedWorklogId=676784&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-676784
]
ASF GitHub Bot logged work on BEAM-11217:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 23:08
Start Date: 04/Nov/21 23:08
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #15887:
URL: https://github.com/apache/beam/pull/15887#discussion_r743256891
##########
File path: sdks/go/pkg/beam/core/runtime/metricsx/metricsx.go
##########
@@ -126,12 +151,12 @@ func extractCounterValue(reader *bytes.Reader) (int64,
error) {
return value, nil
}
-func extractMsecValue(reader *bytes.Reader) (metrics.MsecValue, error) {
+func extractMsecValue(reader *bytes.Reader) (time.Duration, error) {
value, err := coder.DecodeVarInt(reader)
if err != nil {
- return metrics.MsecValue{}, err
+ return time.Millisecond, err
Review comment:
You can simply return `0` here. The compiler will turn the untyped
integer constant to `time.Duration` for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 676784)
Time Spent: 11h 10m (was: 11h)
> Implement metrics filtering
> ---------------------------
>
> Key: BEAM-11217
> URL: https://issues.apache.org/jira/browse/BEAM-11217
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Kamil Wasilewski
> Assignee: Ritesh Ghorse
> Priority: P3
> Labels: stale-assigned
> Time Spent: 11h 10m
> Remaining Estimate: 0h
>
> `metrics.Results` misses a method for querying metrics using a provided
> filter. The method should take a filter object as an argument and return
> `metrics.QueryResults` object containing metrics that matched the filter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
