[
https://issues.apache.org/jira/browse/BEAM-11217?focusedWorklogId=676791&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-676791
]
ASF GitHub Bot logged work on BEAM-11217:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 23:18
Start Date: 04/Nov/21 23:18
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #15887:
URL: https://github.com/apache/beam/pull/15887#discussion_r743266975
##########
File path: sdks/go/pkg/beam/core/metrics/metrics.go
##########
@@ -754,6 +770,19 @@ func (r MsecResult) Result() MsecValue {
return r.Attempted
}
+// Name returns the Name of this Gauge.
+func (r MsecResult) Name() string {
+ return r.Key.Name
+}
+
+// Namespace returns the Namespace of this Gauge.
+func (r MsecResult) Namespace() string {
+ return r.Key.Namespace
+}
Review comment:
Msec results can't have any name or namespaces (or at the very least,
won't have them correctly populated here). return `""` instead for now.
Also, please fix the copypasta "Gauge" references.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 676791)
Time Spent: 11.5h (was: 11h 20m)
> Implement metrics filtering
> ---------------------------
>
> Key: BEAM-11217
> URL: https://issues.apache.org/jira/browse/BEAM-11217
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Kamil Wasilewski
> Assignee: Ritesh Ghorse
> Priority: P3
> Labels: stale-assigned
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> `metrics.Results` misses a method for querying metrics using a provided
> filter. The method should take a filter object as an argument and return
> `metrics.QueryResults` object containing metrics that matched the filter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
