[
https://issues.apache.org/jira/browse/BEAM-11997?focusedWorklogId=678559&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-678559
]
ASF GitHub Bot logged work on BEAM-11997:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/21 15:39
Start Date: 08/Nov/21 15:39
Worklog Time Spent: 10m
Work Description: MiguelAnzoWizeline commented on pull request #15549:
URL: https://github.com/apache/beam/pull/15549#issuecomment-963281851
@lukecwik Hi,
I was testing the implementation that we considered in the previous message,
using an internal ByteKeyRangeTracker gave me some problems with keeping the
range, lastAttemptedKey and lastClaimedKey updated correctly.
The implementation with the new changes I commited works by having a ByteKey
in RedisCursor along with the String cursor representation, and
RedisCursorRangeTracker copies the functionality of ByteKeyRangeTracker (with
the added special conditions of the Redis implementation) using the ByteKey
representation of the cursor to keep track of the range, this works well for
all the read test and seems a cleaner approach.
Still missing the unit test for the new code. I wanted to see first if the
changes looks correct to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 678559)
Time Spent: 5.5h (was: 5h 20m)
> Implement RedisIO on top of Splittable DoFn
> -------------------------------------------
>
> Key: BEAM-11997
> URL: https://issues.apache.org/jira/browse/BEAM-11997
> Project: Beam
> Issue Type: Improvement
> Components: io-java-redis
> Reporter: Boyuan Zhang
> Assignee: Miguel Anzo
> Priority: P2
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
