[ 
https://issues.apache.org/jira/browse/BEAM-11997?focusedWorklogId=679880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-679880
 ]

ASF GitHub Bot logged work on BEAM-11997:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Nov/21 19:47
            Start Date: 10/Nov/21 19:47
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #15549:
URL: https://github.com/apache/beam/pull/15549#discussion_r746934199



##########
File path: 
sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
##########
@@ -334,94 +373,47 @@ public void setup() {
     public void teardown() {
       jedis.close();
     }
-  }
 
-  private static class ReadKeysWithPattern extends BaseReadFn<String> {
-
-    ReadKeysWithPattern(RedisConnectionConfiguration connectionConfiguration) {
-      super(connectionConfiguration);
+    @GetInitialRestriction
+    public RedisCursorRange getInitialRestriction() {
+      long dbSize = jedis.dbSize();

Review comment:
       This needs to be the table size and not the dbsize.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 679880)
    Time Spent: 6h 40m  (was: 6.5h)

> Implement RedisIO on top of Splittable DoFn
> -------------------------------------------
>
>                 Key: BEAM-11997
>                 URL: https://issues.apache.org/jira/browse/BEAM-11997
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-redis
>            Reporter: Boyuan Zhang
>            Assignee: Miguel Anzo
>            Priority: P2
>          Time Spent: 6h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to