[
https://issues.apache.org/jira/browse/BEAM-13183?focusedWorklogId=683100&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-683100
]
ASF GitHub Bot logged work on BEAM-13183:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/21 05:18
Start Date: 18/Nov/21 05:18
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #15819:
URL: https://github.com/apache/beam/pull/15819#discussion_r751912873
##########
File path: sdks/python/build-requirements.txt
##########
@@ -14,6 +14,12 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
+
+# TODO: Consider PEP-517/PEP-518 instead of this file (BEAM-8954).
+
+setuptools
+wheel>=0.36.0
Review comment:
these are common build dependencies, however wheel is not installed by
default into `venv`, but is installed in virtualenv-created env. without this
change, installing from sdist was failing on some python versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 683100)
Remaining Estimate: 0h
Time Spent: 10m
> Use venv instead of virtualenv on to create virtual environments
> ----------------------------------------------------------------
>
> Key: BEAM-13183
> URL: https://issues.apache.org/jira/browse/BEAM-13183
> Project: Beam
> Issue Type: Bug
> Components: build-system, sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Valentyn Tymofieiev
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> venv is a replacement of virtualenv implemented within Python standard
> library.
> I attempted the change in https://github.com/apache/beam/pull/15819.
> Currently the change is not passing Github actions environment check and
> Python 3.6 tests on Jenkins. Need to look closer, but already spent more time
> on this than I anticipated and may need to park this change for now.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
