[ 
https://issues.apache.org/jira/browse/BEAM-13183?focusedWorklogId=683106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-683106
 ]

ASF GitHub Bot logged work on BEAM-13183:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Nov/21 06:03
            Start Date: 18/Nov/21 06:03
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #15819:
URL: https://github.com/apache/beam/pull/15819#discussion_r751929482



##########
File path: .test-infra/jenkins/dependency_check/generate_report.sh
##########
@@ -49,14 +53,14 @@ rm -f 
build/dependencyUpdates/beam-dependency-check-report.txt
 # Insall packages and run the unit tests of the report generator and the jira 
manager
 pip install mock jira pyyaml
 cd $WORKSPACE/src/.test-infra/jenkins
-python -m dependency_check.dependency_check_report_generator_test
-python -m jira_utils.jira_manager_test
-python -m dependency_check.version_comparer_test
+$PYTHON -m dependency_check.dependency_check_report_generator_test
+$PYTHON -m jira_utils.jira_manager_test
+$PYTHON -m dependency_check.version_comparer_test
 
 echo "<html><body>" > 
$WORKSPACE/src/build/dependencyUpdates/beam-dependency-check-report.html
 
-python -m dependency_check.dependency_check_report_generator Python
+$PYTHON -m dependency_check.dependency_check_report_generator Python
 
-python -m dependency_check.dependency_check_report_generator Java
+$PYTHON -m dependency_check.dependency_check_report_generator Java

Review comment:
       seems to work, thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 683106)
    Time Spent: 40m  (was: 0.5h)

> Use venv instead of virtualenv on to create virtual environments
> ----------------------------------------------------------------
>
>                 Key: BEAM-13183
>                 URL: https://issues.apache.org/jira/browse/BEAM-13183
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system, sdk-py-core
>            Reporter: Valentyn Tymofieiev
>            Assignee: Valentyn Tymofieiev
>            Priority: P2
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> venv is a replacement of virtualenv implemented within Python standard 
> library.
> I attempted the change in https://github.com/apache/beam/pull/15819.
> Currently the change is not passing Github actions environment check and 
> Python 3.6 tests on Jenkins. Need to look closer, but already spent more time 
> on this than I anticipated and may need to park this change for now.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to