[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=687679&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687679
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/21 23:39
Start Date: 29/Nov/21 23:39
Worklog Time Spent: 10m
Work Description: benWize commented on a change in pull request #16036:
URL: https://github.com/apache/beam/pull/16036#discussion_r758818779
##########
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/s3/S3FileSystemTest.java
##########
@@ -178,8 +178,7 @@ private void testCopy(S3Options options) throws IOException
{
verify(s3FileSystem.getS3Client(),
times(1)).copyObject(any(CopyObjectRequest.class));
// we simulate a big object >= 5GB so it takes the multiPart path
- HeadObjectResponse bigHeadObjectResponse =
- headObjectResponse.toBuilder().contentLength(5_368_709_120L).build();
+ headObjectResponse.toBuilder().contentLength(5_368_709_120L).build();
Review comment:
I changed it to check the result of the operation into the assert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 687679)
Time Spent: 42h 40m (was: 42.5h)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 42h 40m
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
