[
https://issues.apache.org/jira/browse/BEAM-11936?focusedWorklogId=687586&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687586
]
ASF GitHub Bot logged work on BEAM-11936:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/21 20:06
Start Date: 29/Nov/21 20:06
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#16033:
URL: https://github.com/apache/beam/pull/16033#discussion_r758651148
##########
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/BatchRequestForDLP.java
##########
@@ -39,6 +39,8 @@
/** Batches input rows to reduce number of requests sent to Cloud DLP service.
*/
@Experimental
+// TODO(BEAM-11936): Remove when new version of errorprone is released (2.11.0)
Review comment:
```suggestion
// TODO(BEAM-13271): Remove when new version of errorprone is released
(2.11.0)
```
##########
File path:
sdks/java/extensions/sketching/src/test/java/org/apache/beam/sdk/extensions/sketching/TDigestQuantilesTest.java
##########
@@ -118,7 +118,7 @@ public void testMergeAccum() {
accums.add(std);
}
TDigestQuantilesFn fn = TDigestQuantilesFn.create(100);
- MergingDigest res = fn.mergeAccumulators(accums);
+ fn.mergeAccumulators(accums);
Review comment:
Hm this actually looks like a bug. It should probably verify something
about res (e.g. that it contains everything from accums). Could you try this:
```suggestion
MergingDigest res = fn.mergeAccumulators(accums);
assertThat(res.size(), equals(1000));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 687586)
Time Spent: 40h 50m (was: 40h 40m)
> Fix errorprone 2.3.4 ignored warnings
> -------------------------------------
>
> Key: BEAM-11936
> URL: https://issues.apache.org/jira/browse/BEAM-11936
> Project: Beam
> Issue Type: Task
> Components: build-system, runner-core, sdk-java-core,
> sdk-java-harness
> Reporter: Brian Hulette
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 40h 50m
> Remaining Estimate: 0h
>
> Upgrading to errorprone 2.3.4 (https://github.com/apache/beam/pull/14148)
> required ignoring a lot of new warnings. We should fix the offending code and
> re-enable these warnings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
