[
https://issues.apache.org/jira/browse/BEAM-928?focusedWorklogId=217415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-217415
]
ASF GitHub Bot logged work on BEAM-928:
---------------------------------------
Author: ASF GitHub Bot
Created on: 22/Mar/19 19:43
Start Date: 22/Mar/19 19:43
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #8120: [BEAM-928]
Enable Spotbugs in KafkaIO, fix warnings
URL: https://github.com/apache/beam/pull/8120#discussion_r268313979
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaExactlyOnceSink.java
##########
@@ -520,6 +521,7 @@ void commitTxn(long lastRecordId, Counter numTransactions)
throws IOException {
}
}
+ @SuppressFBWarnings("REC_CATCH_EXCEPTION")
Review comment:
The goal of the JIRA is to fix the warnings, in this case deal with the
different exceptions. Can't this be fixed?
If it is really impossible to fix, prefer using the `findbugs-filter.xml`
(or `spotbugs-filter.xml`) file to do the exclusions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 217415)
Time Spent: 0.5h (was: 20m)
> Enable Spotbugs in KafkaIO
> --------------------------
>
> Key: BEAM-928
> URL: https://issues.apache.org/jira/browse/BEAM-928
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-kafka
> Reporter: Daniel Halperin
> Assignee: Raghu Angadi
> Priority: Major
> Labels: triaged
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {code}
> [INFO] Inconsistent synchronization of
> org.apache.beam.sdk.io.kafka.KafkaIO$UnboundedKafkaReader$PartitionState.latestOffset;
> locked 75% of time
> [org.apache.beam.sdk.io.kafka.KafkaIO$UnboundedKafkaReader,
> org.apache.beam.sdk.io.kafka.KafkaIO$UnboundedKafkaReader$PartitionState,
> org.apache.beam.sdk.io.kafka.KafkaIO$UnboundedKafkaReader$PartitionState,
> org.apache.beam.sdk.io.kafka.KafkaIO$UnboundedKafkaReader$PartitionState]
> Unsynchronized access at KafkaIO.java:[line 1064]Synchronized access at
> KafkaIO.java:[line 822]Synchronized access at KafkaIO.java:[line
> 827]Synchronized access at KafkaIO.java:[line 830]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
