[
https://issues.apache.org/jira/browse/BEAM-928?focusedWorklogId=217895&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-217895
]
ASF GitHub Bot logged work on BEAM-928:
---------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/19 09:57
Start Date: 25/Mar/19 09:57
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #8120:
[BEAM-928] Enable Spotbugs in KafkaIO, fix warnings
URL: https://github.com/apache/beam/pull/8120#discussion_r268560576
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaRecord.java
##########
@@ -28,7 +27,7 @@
* KafkaRecord contains key and value of the record as well as metadata for
the record (topic name,
* partition id, and offset).
*/
-public class KafkaRecord<K, V> implements Serializable {
+public class KafkaRecord<K, V> {
Review comment:
For payload we use coders, don't we? `KafkaRecordCoder` is used for
`KafkaRecord` in this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 217895)
Time Spent: 40m (was: 0.5h)
> Enable Spotbugs in KafkaIO
> --------------------------
>
> Key: BEAM-928
> URL: https://issues.apache.org/jira/browse/BEAM-928
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-kafka
> Reporter: Daniel Halperin
> Assignee: Raghu Angadi
> Priority: Major
> Labels: triaged
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {code}
> [INFO] Inconsistent synchronization of
> org.apache.beam.sdk.io.kafka.KafkaIO$UnboundedKafkaReader$PartitionState.latestOffset;
> locked 75% of time
> [org.apache.beam.sdk.io.kafka.KafkaIO$UnboundedKafkaReader,
> org.apache.beam.sdk.io.kafka.KafkaIO$UnboundedKafkaReader$PartitionState,
> org.apache.beam.sdk.io.kafka.KafkaIO$UnboundedKafkaReader$PartitionState,
> org.apache.beam.sdk.io.kafka.KafkaIO$UnboundedKafkaReader$PartitionState]
> Unsynchronized access at KafkaIO.java:[line 1064]Synchronized access at
> KafkaIO.java:[line 822]Synchronized access at KafkaIO.java:[line
> 827]Synchronized access at KafkaIO.java:[line 830]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
