[ 
https://issues.apache.org/jira/browse/BEAM-13263?focusedWorklogId=695343&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-695343
 ]

ASF GitHub Bot logged work on BEAM-13263:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Dec/21 20:47
            Start Date: 13/Dec/21 20:47
    Worklog Time Spent: 10m 
      Work Description: je-ik commented on a change in pull request #15994:
URL: https://github.com/apache/beam/pull/15994#discussion_r768109523



##########
File path: 
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/state/FlinkStateInternals.java
##########
@@ -215,6 +216,22 @@ public void clearGlobalState() {
     }
   }
 
+  public List<ByteBuffer> getGlobalWindowStateKeys() {

Review comment:
       Ah, my bad.
   
   In the case of memory complexity, I think there are few solutions, that 
would not be a sort of overengineering - without the proof there exists a need 
of such a complex solution. IMO, the cleanest would be to enhance the Flink 
state iteration API to provide appropriate guarantees (e.g. sorted keys), and 
deduplicate in-mem until such API is available.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 695343)
    Time Spent: 3h 10m  (was: 3h)

> Support OnWindowExpiration in Flink runner
> ------------------------------------------
>
>                 Key: BEAM-13263
>                 URL: https://issues.apache.org/jira/browse/BEAM-13263
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-flink
>            Reporter: Reuven Lax
>            Priority: P2
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to