[ 
https://issues.apache.org/jira/browse/BEAM-13263?focusedWorklogId=695355&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-695355
 ]

ASF GitHub Bot logged work on BEAM-13263:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Dec/21 21:01
            Start Date: 13/Dec/21 21:01
    Worklog Time Spent: 10m 
      Work Description: dmvk commented on a change in pull request #15994:
URL: https://github.com/apache/beam/pull/15994#discussion_r768118387



##########
File path: 
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/state/FlinkStateInternals.java
##########
@@ -215,6 +216,22 @@ public void clearGlobalState() {
     }
   }
 
+  public List<ByteBuffer> getGlobalWindowStateKeys() {

Review comment:
       I would say `org.apache.flink.runtime.state.KeyedStateBackend#getKeys` 
[1] should already provide everything you need. You just need to make sure you 
have a state that you can rely on.
   
   If you think about it, you'd also need to make sure there is _some_ state in 
the approach you're proposing, so it's not that different.
   
   [1] 
https://nightlies.apache.org/flink/flink-docs-master/api/java/org/apache/flink/runtime/state/KeyedStateBackend.html#getKeys-java.lang.String-N-




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 695355)
    Time Spent: 4h 20m  (was: 4h 10m)

> Support OnWindowExpiration in Flink runner
> ------------------------------------------
>
>                 Key: BEAM-13263
>                 URL: https://issues.apache.org/jira/browse/BEAM-13263
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-flink
>            Reporter: Reuven Lax
>            Priority: P2
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to