[
https://issues.apache.org/jira/browse/BEAM-13541?focusedWorklogId=702422&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-702422
]
ASF GitHub Bot logged work on BEAM-13541:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Dec/21 19:43
Start Date: 30/Dec/21 19:43
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #16354:
URL: https://github.com/apache/beam/pull/16354#discussion_r776847859
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGbkResult.java
##########
@@ -59,6 +60,8 @@
private static final int DEFAULT_IN_MEMORY_ELEMENT_COUNT = 10_000;
+ private static final int DEFAULT_MIN_ELEMENTS_PER_TAG = 100;
Review comment:
The idea is that we will cache always at least this many values per tag,
regardless of whether DEFAULT_IN_MEMORY_ELEMENT_COUNT was "used up" for other
tags. I'll clarify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 702422)
Time Spent: 2h 10m (was: 2h)
> Use runtime information to improve CoGroupByKey caching
> -------------------------------------------------------
>
> Key: BEAM-13541
> URL: https://issues.apache.org/jira/browse/BEAM-13541
> Project: Beam
> Issue Type: Improvement
> Components: sdk-ideas
> Reporter: Sunil Pedapudi
> Assignee: Robert Bradshaw
> Priority: P0
> Fix For: 2.36.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently, CoGroupByKey creates UnionTables that are Flattened. The Flattened
> output is processed by a GroupByKey to produce a CoGbkResult (via
> ConstructCoGbkResultFn).
>
> Given the performance of CoGBK is greatly impacted based on the which
> elements are cached in the (finitely sized) in-memory results, it would be
> useful if CoGbkResult can use runtime information to prioritize which
> elements are stored in-memory.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
