[
https://issues.apache.org/jira/browse/BEAM-13541?focusedWorklogId=702432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-702432
]
ASF GitHub Bot logged work on BEAM-13541:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Dec/21 19:58
Start Date: 30/Dec/21 19:58
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #16354:
URL: https://github.com/apache/beam/pull/16354#discussion_r776851490
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGbkResult.java
##########
@@ -98,8 +104,7 @@ public CoGbkResult(
throw new IllegalStateException(
"union tag " + unionTag + " has no corresponding tuple tag in the
result schema");
}
- List<Object> valueList = (List<Object>) valueMap.get(unionTag);
- valueList.add(value.getValue());
+ valuesByTag.get(unionTag).add(value.getValue());
}
if (taggedIter.hasNext()) {
Review comment:
There are pros and cons to this, but I agree it's a slight improvement.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 702432)
Time Spent: 2h 50m (was: 2h 40m)
> Use runtime information to improve CoGroupByKey caching
> -------------------------------------------------------
>
> Key: BEAM-13541
> URL: https://issues.apache.org/jira/browse/BEAM-13541
> Project: Beam
> Issue Type: Improvement
> Components: sdk-ideas
> Reporter: Sunil Pedapudi
> Assignee: Robert Bradshaw
> Priority: P0
> Fix For: 2.36.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Currently, CoGroupByKey creates UnionTables that are Flattened. The Flattened
> output is processed by a GroupByKey to produce a CoGbkResult (via
> ConstructCoGbkResultFn).
>
> Given the performance of CoGBK is greatly impacted based on the which
> elements are cached in the (finitely sized) in-memory results, it would be
> useful if CoGbkResult can use runtime information to prioritize which
> elements are stored in-memory.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
