[
https://issues.apache.org/jira/browse/BEAM-11808?focusedWorklogId=708784&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708784
]
ASF GitHub Bot logged work on BEAM-11808:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/22 01:10
Start Date: 14/Jan/22 01:10
Worklog Time Spent: 10m
Work Description: benWize commented on a change in pull request #16200:
URL: https://github.com/apache/beam/pull/16200#discussion_r784438905
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java
##########
@@ -240,18 +244,22 @@ private AggregateCall convertAggCall(
}
List<Integer> argList = new ArrayList<>();
- for (ResolvedExpr expr :
- ((ResolvedAggregateFunctionCall)
computedColumn.getExpr()).getArgumentList()) {
+ ResolvedAggregateFunctionCall expr = ((ResolvedAggregateFunctionCall)
computedColumn.getExpr());
+ List<ZetaSQLResolvedNodeKind.ResolvedNodeKind> resolvedNodeKinds =
+ Arrays.asList(RESOLVED_CAST, RESOLVED_COLUMN_REF,
RESOLVED_GET_STRUCT_FIELD);
+ for (int i = 0; i < expr.getArgumentList().size(); i++) {
// Throw an error if aggregate function's input isn't either a ColumnRef
or a cast(ColumnRef).
// TODO: is there a general way to handle aggregation calls conversion?
- if (expr.nodeKind() == RESOLVED_CAST
- || expr.nodeKind() == RESOLVED_COLUMN_REF
- || expr.nodeKind() == RESOLVED_GET_STRUCT_FIELD) {
+ ZetaSQLResolvedNodeKind.ResolvedNodeKind resolvedNodeKind =
+ expr.getArgumentList().get(i).nodeKind();
+ if (i == 0 && resolvedNodeKinds.contains(resolvedNodeKind)) {
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 708784)
Time Spent: 5h 20m (was: 5h 10m)
> ZetaSQL layer doesn't support aggregate functions with two arguments
> ---------------------------------------------------------------------
>
> Key: BEAM-11808
> URL: https://issues.apache.org/jira/browse/BEAM-11808
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Sonam Ramchand
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> Blocked by: parsed ZetaSQL to a Calcite logical expression doesn't currently
> support aggregate functions with multiple columns.
> [https://github.com/apache/beam/blob/3bb232fb098700de408f574585dfe74bbaff7230/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java#L147]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
