[
https://issues.apache.org/jira/browse/BEAM-11808?focusedWorklogId=710845&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-710845
]
ASF GitHub Bot logged work on BEAM-11808:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jan/22 20:24
Start Date: 18/Jan/22 20:24
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #16200:
URL: https://github.com/apache/beam/pull/16200#issuecomment-1010484119
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#16200](https://codecov.io/gh/apache/beam/pull/16200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(3d92b4f) into
[master](https://codecov.io/gh/apache/beam/commit/0a220a1c6bea81adcc04cca1977705f2b5e93b0d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(0a220a1) will **increase** coverage by `8.98%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 3d92b4f differs from pull request most recent
head 8760842. Consider uploading reports for the commit 8760842 to get more
accurate results
[](https://codecov.io/gh/apache/beam/pull/16200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16200 +/- ##
==========================================
+ Coverage 74.60% 83.59% +8.98%
==========================================
Files 653 452 -201
Lines 81798 62001 -19797
==========================================
- Hits 61029 51830 -9199
+ Misses 19788 10171 -9617
+ Partials 981 0 -981
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/16200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/16200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=)
| `87.80% <0.00%> (-2.44%)` | :arrow_down: |
|
[sdks/python/apache\_beam/dataframe/transforms.py](https://codecov.io/gh/apache/beam/pull/16200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3RyYW5zZm9ybXMucHk=)
| `94.92% <0.00%> (-0.34%)` | :arrow_down: |
|
[sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/16200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=)
| `89.98% <0.00%> (-0.15%)` | :arrow_down: |
|
[...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/16200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==)
| `90.80% <0.00%> (-0.11%)` | :arrow_down: |
|
[sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/16200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5)
| `95.86% <0.00%> (-0.11%)` | :arrow_down: |
|
[sdks/python/apache\_beam/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/16200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tZXRyaWMucHk=)
| `95.38% <0.00%> (ø)` | |
|
[sdks/python/apache\_beam/dataframe/expressions.py](https://codecov.io/gh/apache/beam/pull/16200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2V4cHJlc3Npb25zLnB5)
| `92.90% <0.00%> (ø)` | |
|
[sdks/go/pkg/beam/core/runtime/exec/plan.go](https://codecov.io/gh/apache/beam/pull/16200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9wbGFuLmdv)
| | |
|
[sdks/go/pkg/beam/core/runtime/metricsx/urns.go](https://codecov.io/gh/apache/beam/pull/16200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvbWV0cmljc3gvdXJucy5nbw==)
| | |
|
[sdks/go/pkg/beam/core/util/reflectx/call.go](https://codecov.io/gh/apache/beam/pull/16200/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3V0aWwvcmVmbGVjdHgvY2FsbC5nbw==)
| | |
| ... and [201
more](https://codecov.io/gh/apache/beam/pull/16200/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/16200?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/16200?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[0a220a1...8760842](https://codecov.io/gh/apache/beam/pull/16200?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 710845)
Time Spent: 6h 10m (was: 6h)
> ZetaSQL layer doesn't support aggregate functions with two arguments
> ---------------------------------------------------------------------
>
> Key: BEAM-11808
> URL: https://issues.apache.org/jira/browse/BEAM-11808
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Sonam Ramchand
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> Blocked by: parsed ZetaSQL to a Calcite logical expression doesn't currently
> support aggregate functions with multiple columns.
> [https://github.com/apache/beam/blob/3bb232fb098700de408f574585dfe74bbaff7230/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java#L147]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
