[
https://issues.apache.org/jira/browse/BEAM-13051?focusedWorklogId=710873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-710873
]
ASF GitHub Bot logged work on BEAM-13051:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jan/22 20:50
Start Date: 18/Jan/22 20:50
Worklog Time Spent: 10m
Work Description: andoni-guzman commented on pull request #16541:
URL: https://github.com/apache/beam/pull/16541#issuecomment-1015822782
In the last commit I delete two more warnings.
**- raising-non-exception
- super-on-old-class**
Both of them are not present in pylint local tests.
This warning ( **not-callable**) it's seems to be a false positive in the
code. Pyline doesn't recognize as a class or a function if it's declared in
some ways. Also seems like a know issue
https://github.com/PyCQA/pylint/issues/2562
Something similar happen with **redundant-keyword-arg** , this case happen
with partial functions like beam use in "@deprecated" decorator. Also seems to
be a know issue https://github.com/PyCQA/pylint/issues/2271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 710873)
Time Spent: 2h 20m (was: 2h 10m)
> Enable all practical pylint warnings
> ------------------------------------
>
> Key: BEAM-13051
> URL: https://issues.apache.org/jira/browse/BEAM-13051
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Mike Hernandez
> Priority: P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> We currently have 75 pylint checks disabled globally:
> https://github.com/apache/beam/blob/0863d95205410567a7ab191fd0a46308a0d54bb7/sdks/python/.pylintrc#L81
> I think some of these are impractical for Beam (e.g.
> [super-init-not-called|https://pycodequ.al/docs/pylint-messages/w0231-super-init-not-called.html]
> because of BEAM-6158), but most of them are verifying good conventions that
> we should try to stick to. Let's enable as many of the checks as possible,
> such that the only disabled checks are really impractical for Beam, or are
> incompatible with the Beam community's coding style.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
