[
https://issues.apache.org/jira/browse/BEAM-13051?focusedWorklogId=712252&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712252
]
ASF GitHub Bot logged work on BEAM-13051:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/22 18:01
Start Date: 20/Jan/22 18:01
Worklog Time Spent: 10m
Work Description: roger-mike commented on a change in pull request #16521:
URL: https://github.com/apache/beam/pull/16521#discussion_r789017255
##########
File path: sdks/python/.pylintrc
##########
@@ -97,7 +96,6 @@ disable =
cyclic-import,
design,
fixme,
- function-redefined,
Review comment:
Besides the warning in `DecoratorsTest`, it throws warnings on some
decorators and type hints tests, and also some DoFns and PTransform
redefinitions. Seems like this warning could be disabled since the warnings
seem to be coherent with what is being tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 712252)
Time Spent: 3h 50m (was: 3h 40m)
> Enable all practical pylint warnings
> ------------------------------------
>
> Key: BEAM-13051
> URL: https://issues.apache.org/jira/browse/BEAM-13051
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Mike Hernandez
> Priority: P2
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> We currently have 75 pylint checks disabled globally:
> https://github.com/apache/beam/blob/0863d95205410567a7ab191fd0a46308a0d54bb7/sdks/python/.pylintrc#L81
> I think some of these are impractical for Beam (e.g.
> [super-init-not-called|https://pycodequ.al/docs/pylint-messages/w0231-super-init-not-called.html]
> because of BEAM-6158), but most of them are verifying good conventions that
> we should try to stick to. Let's enable as many of the checks as possible,
> such that the only disabled checks are really impractical for Beam, or are
> incompatible with the Beam community's coding style.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
